Repository navigation
Revise vertical spacing between elements - #261
Merged
Merged
Conversation
The article CSS file has grown hugely with recent component additions. This first update splits them into separate files before making any changes.
Reviewed all pages on both desktop and mobile to verify it's all looking good.
johnsBeharry
previously approved these changes
Apr 29, 2021
Contributor
Useful debug css: <style>* { outline: 1px solid red; }</style> |
Collaborator
|
Thanks for the improvement, did a very brief visual look through and the spacing between headers is a lot better 🚧 |
pavlenex
approved these changes
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first PR to address issue #231.
The first part of this is more organizational to make the CSS easier to work with. Article.scss had grown hugely in size and become hard to work with. By splitting the CSS into individual files, it becomes easier to implement the fixes that have been requested for spacing.
The second part is addressing various spacing issues that had been mentioned over time.